Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-date-input): add support for custom calendar icon #1816

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

szalonna
Copy link
Contributor

@szalonna szalonna commented Dec 9, 2024

Closes: CLX-260

Copy link

github-actions bot commented Dec 9, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-11 13:33 UTC

@szalonna szalonna self-assigned this Dec 9, 2024
@szalonna
Copy link
Contributor Author

szalonna commented Dec 9, 2024

The tests are pending as Chromatic needs a manual approve for the new examples in Storybook

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! please squash the commits into one feat() commit and we'll merge it

@szalonna
Copy link
Contributor Author

Should I approve the Chromatic tests or should it be you?

@szalonna szalonna force-pushed the feature/CLX-260-dateinput2-custom-icon branch from 24334c7 to 46a9cbb Compare December 10, 2024 13:31
@matyasf matyasf merged commit a0fff9d into master Dec 11, 2024
11 checks passed
@matyasf matyasf deleted the feature/CLX-260-dateinput2-custom-icon branch December 11, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants